Move tag next/prev buttons to the left#4751
Conversation
Move the tag next/prev buttons to the left so that you don't have to move your mouse cursor all the way across the screen when clicking between the dropdown and these two buttons. This is especially noticeable on wide screen monitors.
|
@IgorA100 what do you think? I get the idea RE less mouse travel... but it feels wrong from a UI perspective to put them on the left. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Reorders the tag navigation controls in the event view so the Prev/Next tag buttons appear to the left of the tag dropdown, reducing mouse travel on wide screens.
Changes:
- Moved the tag dropdown markup to appear after the Prev/Next buttons within the tags container.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <button type="button" id="tagNextBtn" title="<?php echo translate('Apply the last tag, then play the next event') ?>" class="inactive" data-on-click-true="tagAndNext"> | ||
| <i class="material-icons md-18">label</i> | ||
| </button> | ||
| <div class="tag-dropdown"> | ||
| <!-- input type has to be "search" (not "text") so that the Enter button (not Next) works on mobile Chrome browser. --> | ||
| <input type="search" id="tagInput" class="tag-input" placeholder="Add tag" data-role="tagsinput"> | ||
| <div class="tag-dropdown-content"></div> | ||
| </div> |
Yes, I agree. |
|
@IgorA100 You're solving a problem that doesn't exist. The keyboard controls have been there since tags were originally implemented. This fix is specifically to reduce mouse movement when using the mouse to add tags. You obviously don't use the tags functionality. I tag over 1000 events daily and routinely switch between using the mouse and keyboard. The mouse is definitely easier to use when adding tags. Let's concentrate on simplifying the mouse movement when adding tags. |
You probably don't use the keyboard to assign tags, but only the mouse. After my PR, you can put the mouse aside and use only the keyboard. Although no, you'll still need to make one mouse click – click "#tagInput." |
You probably haven't read the description of my PR and haven't tried using it. |
|
SMH... This issue is around mouse movement. Not keyboard usage. The keyboard already works and is well documented. https://zoneminder.readthedocs.io/en/latest/userguide/tags.html#adding-existing-tags-to-an-event Reduce mouse movement. |
This further confirms that you didn't read my PR description or try it. |
|
You're powerless because you are not trying to reduce mouse movement. No keyboard involved. |
|
@Simpler1
This way, you practically don't need a mouse at all, and the speed of entering tags increases significantly!!! @connortechnology |
Perhaps you're being disingenuous... |
|
I add the same tags over an over. You don't even understand the issue. Please stop trying to change the subject. Do you understand what the "next/prev" tag buttons actually even do??? |
|
Minor improvement: #4796 |
Probably not. |
|
I agree with copilot above. This should be done in CSS. I may merge, but apply copilots fix. |
I'll let you in on a big secret. The "Ctrl" + "Right" and "Ctrl" + "Left" key combinations are the exact equivalent of the "next/prev" tag buttons. |
Move the tag next/prev buttons to the left so that you don't have to move your mouse cursor all the way across the screen when clicking between the dropdown and these two buttons. This is especially noticeable on wide screen monitors.